Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct styles import in block mobile toolbar #18935

Merged
merged 1 commit into from
Dec 5, 2019
Merged

Correct styles import in block mobile toolbar #18935

merged 1 commit into from
Dec 5, 2019

Conversation

lukewalczak
Copy link
Member

@lukewalczak lukewalczak commented Dec 5, 2019 •
edited
Loading

Description

That PR is fixing failing CI on gb-mobile, because of wrong styles import within block-mobile-toolbar/index.native.js

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR. .

@lukewalczak lukewalczak added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Dec 5, 2019
@lukewalczak lukewalczak self-assigned this Dec 5, 2019
pinarol
pinarol approved these changes Dec 5, 2019
View reviewed changes
Copy link
Contributor

@pinarol pinarol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hypest hypest mentioned this pull request Dec 5, 2019
Merged
@lukewalczak lukewalczak merged commit a8c0ca9 into master Dec 5, 2019
@lukewalczak lukewalczak deleted the fix/correct-import branch December 5, 2019 10:14
@youknowriad youknowriad added this to the Gutenberg 7.1 milestone Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinarol pinarol pinarol approved these changes

Assignees

@lukewalczak lukewalczak

Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Milestone
Gutenberg 7.1
Development

Successfully merging this pull request may close these issues.
3 participants
@lukewalczak @pinarol @youknowriad